fix: Drizzle Read Connection Concurrency#765
Merged
stevensJourney merged 14 commits intomainfrom Nov 12, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 7e4810d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
Chriztiaan
approved these changes
Nov 12, 2025
rkistner
approved these changes
Nov 12, 2025
Collaborator
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
should close #763
The current Drizzle driver uses the
AbstractPowerSyncDatabasewriteLockmethod for most query operations. Read locks are only used if an explicitread onlytransaction is started.Using a write lock for Select queries hampers concurrency in applications using environments which support multiple read connections - such as React Native and Node.js. Thanks @rkistner for adding this!
This PR updates the query execution logic to use
queryMetaDatafrom drizzle-team/drizzle-orm#4447 in order to detectSELECTqueries. This approach has some limitations:queryMetaDatais not available fordb.query[collectionName]queries. We use a slightly nasty override fordb.query[collectionName]queries. The current version only hasfindManyandfirstFirstoptions - which should be read queries